metrics improvement #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dealloc
added
documentation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/Helldivers-2-API/Middlewares/RedirectFlyDomainMiddleware.cs
Dismissed
Show dismissed
Hide dismissed
chatterchats
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR expands the metrics implemented in #87
It adds normalization for the Client name that is currently exported, as Prometheus currently reports things like this:
note that it contains duplicate domains (like
divers.gg) because it also records the path, andheckdivershas multiple Netlify URLS, these all get normalized and aggregated in proper client names.It also documents and adds support for the
X-Super-Clientheader that clients should start sending ASAP (we'll be providing PR for most developers we can identify and find GH for) to further improve client detection in the future.This is the first PR towards #94